backport to 1.20

# Conflicts:
#	common/src/main/java/net/lionarius/skinrestorer/mixin/ServerLoginPacketListenerImplMixin.java

.gitignore

@@ -30,4 +30,3 @@ bin/
 
 .architectury-transformer/
 run/
-scripts/

CHANGELOG.md

@@ -4,44 +4,6 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [2.5.0] - 2026-01-14
-### Added
-- Added collection skin provider (allows assigning random skins from a predefined set)
-- Added `forceFirstJoinSkinFetch` config option to force skin fetch on first join even if player already has a skin
-
-## [2.4.3] - 2025-07-25
-### Fixed
-- Fixed crash on client when loading player head skin (fixes [#63](https://github.com/Suiranoil/SkinRestorer/issues/63) and [#64](https://github.com/Suiranoil/SkinRestorer/issues/64))
-- Fixed server freeze when loading player head skin
-
-## [2.4.2] - 2025-07-13
-### Fixed
-- Fix crash when head profile name is null (fixes [#60](https://github.com/Suiranoil/SkinRestorer/issues/60) and [#61](https://github.com/Suiranoil/SkinRestorer/issues/61))
-
-## [2.4.1] - 2025-07-09
-### Changed
-- Log full exception and argument when unable to fetch/set skin
-### Fixed
-- Fixed mojang provider using offline uuids when unable to fetch actual uuid resulting in `no profile with uuid` error
-
-## [2.4.0] - 2025-07-05
-### Fixed
-- Added support for player heads
-
-## [2.3.5] - 2025-06-21
-### Fixed
-- Fix mod not loading on client
-
-## [2.3.4] - 2025-06-19
-### Added
-- Added support for minecraft 1.21.6
-
-## [2.3.3] - 2025-06-01
-### Fixed
-- Fixed forge mixin crash (closes [#54](https://github.com/Suiranoil/SkinRestorer/issues/53))
-### Removed
-- Removed minecraft 1.19 support
-
 ## [2.3.2] - 2025-05-24
 ### Fixed
 - Fixed mixin incompatibility with ModernFix (closes [#42](https://github.com/Suiranoil/SkinRestorer/issues/52))

CHANGELOG_LATEST.md

@@ -1,3 +1,2 @@
-### Added
-- Added collection skin provider (allows assigning random skins from a predefined set) (see [wiki](https://github.com/Suiranoil/SkinRestorer/wiki/Configuration#providerscollection))
-- Added `forceFirstJoinSkinFetch` config option to force skin fetch on first join even if player already has a skin (see [wiki](https://github.com/Suiranoil/SkinRestorer/wiki/Configuration#forcefirstjoinskinfetch))
+### Fixed
+- Fixed mixin incompatibility with ModernFix (closes [#42](https://github.com/Suiranoil/SkinRestorer/issues/52))

buildSrc/src/main/groovy/multiloader-publish.gradle

@@ -3,17 +3,14 @@ plugins {
 }
 
 publishMods {
-    file = project.layout.buildDirectory.file("libs/${project.archivesBaseName}-${project.version}.jar").map { it.asFile }.getOrNull()
+    if (project.name == 'fabric')
+        file = remapJar.archiveFile
+    else if (project.name == 'neoforge')
+        file = jar.archiveFile
+    else
+        file = tasks.named('jarJar').get().archiveFile
 
     modLoaders.add(project.name)
-
-    if (project.hasProperty('additional_modloaders') && !additional_modloaders.isEmpty())
-    {
-        def loaders = additional_modloaders.split(',')
-        for (loader in loaders)
-            modLoaders.add(loader)
-    }
-    
     type = STABLE
     version = project.version
     displayName = "[${project.name.capitalize()}] ${mod_name} ${mod_version}"

common/src/main/java/net/lionarius/skinrestorer/SkinRestorer.java

@@ -1,12 +1,10 @@
 package net.lionarius.skinrestorer;
 
-import com.google.common.base.Throwables;
 import com.mojang.authlib.GameProfile;
 import com.mojang.brigadier.CommandDispatcher;
 import net.lionarius.skinrestorer.command.SkinCommand;
 import net.lionarius.skinrestorer.config.Config;
 import net.lionarius.skinrestorer.config.provider.BuiltInProviderConfig;
-import net.lionarius.skinrestorer.exception.TransparentException;
 import net.lionarius.skinrestorer.platform.Services;
 import net.lionarius.skinrestorer.skin.SkinIO;
 import net.lionarius.skinrestorer.skin.SkinStorage;
@@ -19,7 +17,6 @@ import net.minecraft.resources.ResourceLocation;
 import net.minecraft.server.MinecraftServer;
 import net.minecraft.server.level.ServerPlayer;
 import net.minecraft.world.level.storage.LevelResource;
-import org.jetbrains.annotations.Nullable;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -38,7 +35,6 @@ public final class SkinRestorer {
     private static Path configDir;
     private static Config config;
     private static TickedScheduler tickedScheduler;
-    private static MinecraftServer minecraftServer;
     
     private SkinRestorer() {}
     
@@ -62,10 +58,6 @@ public final class SkinRestorer {
         return SkinRestorer.tickedScheduler;
     }
     
-    public static @Nullable MinecraftServer getMinecraftServer() {
-        return SkinRestorer.minecraftServer;
-    }
-    
     public static Optional<SkinProvider> getProvider(String name) {
         return Optional.ofNullable(SkinRestorer.providersRegistry.get(name));
     }
@@ -88,7 +80,6 @@ public final class SkinRestorer {
         SkinRestorer.registerDefaultSkinProvider(MojangSkinProvider.PROVIDER_NAME, SkinProvider.MOJANG, SkinRestorer.getConfig().providersConfig().mojang());
         SkinRestorer.registerDefaultSkinProvider(ElyBySkinProvider.PROVIDER_NAME, SkinProvider.ELY_BY, SkinRestorer.getConfig().providersConfig().ely_by());
         SkinRestorer.registerDefaultSkinProvider(MineskinSkinProvider.PROVIDER_NAME, SkinProvider.MINESKIN, SkinRestorer.getConfig().providersConfig().mineskin());
-        SkinRestorer.registerDefaultSkinProvider(CollectionSkinProvider.PROVIDER_NAME, SkinProvider.COLLECTION, SkinRestorer.getConfig().providersConfig().collection());
     }
     
     private static void registerDefaultSkinProvider(String defaultName, SkinProvider provider, BuiltInProviderConfig config) {
@@ -107,7 +98,6 @@ public final class SkinRestorer {
         MojangSkinProvider.reload();
         ElyBySkinProvider.reload();
         MineskinSkinProvider.reload();
-        CollectionSkinProvider.reload();
     }
     
     public static Collection<ServerPlayer> applySkin(MinecraftServer server, Iterable<GameProfile> targets, SkinValue value, boolean save) {
@@ -157,7 +147,7 @@ public final class SkinRestorer {
                     
                     var skinResult = result.get();
                     if (skinResult.isError())
-                        throw new TransparentException(Throwables.getRootCause(skinResult.getErrorValue()));
+                        return Result.<Collection<ServerPlayer>, String>error(skinResult.getErrorValue().getMessage());
                     
                     var skinValue = SkinValue.fromProviderContextWithValue(context, skinResult.getSuccessValue().orElse(null));
                     
@@ -166,7 +156,7 @@ public final class SkinRestorer {
                     return Result.<Collection<ServerPlayer>, String>success(acceptedPlayers);
                 }, server)
                 .exceptionally(e -> {
-                    SkinRestorer.LOGGER.error("Failed to set skin '{}:{}'", context.name(), context.argument(), e);
+                    SkinRestorer.LOGGER.error(e.toString());
                     return Result.error(e.getMessage());
                 });
     }
@@ -181,14 +171,6 @@ public final class SkinRestorer {
             SkinRestorer.skinStorage = new SkinStorage(new SkinIO(worldSkinDirectory));
             SkinRestorer.tickedScheduler = new TickedScheduler(server);
             server.addTickable(SkinRestorer.tickedScheduler);
-            
-            SkinRestorer.minecraftServer = server;
-        }
-        
-        public static void onServerStopped(MinecraftServer server) {
-            SkinRestorer.skinStorage = null;
-            SkinRestorer.tickedScheduler = null;
-            SkinRestorer.minecraftServer = null;
         }
         
         public static void onCommandRegister(CommandDispatcher<CommandSourceStack> dispatcher) {

common/src/main/java/net/lionarius/skinrestorer/compat/skinshuffle/SkinShuffleCompatibility.java

@@ -34,7 +34,7 @@ public class SkinShuffleCompatibility {
     public static void handleSkinRefresh(MinecraftServer server, ServerPlayer player, SkinShuffleSkinRefreshPayload payload) {
         var property = payload.textureProperty();
         
-        if (!property.name().equals(PlayerUtils.TEXTURES_KEY))
+        if (!property.getName().equals(PlayerUtils.TEXTURES_KEY))
             return;
         
         if (!property.hasSignature())

common/src/main/java/net/lionarius/skinrestorer/compat/skinshuffle/SkinShuffleHandshakePayload.java

@@ -1,23 +1,10 @@
 package net.lionarius.skinrestorer.compat.skinshuffle;
 
-import net.minecraft.network.FriendlyByteBuf;
-import net.minecraft.network.protocol.common.custom.CustomPacketPayload;
 import net.minecraft.resources.ResourceLocation;
-import org.jetbrains.annotations.NotNull;
 
-public record SkinShuffleHandshakePayload() implements CustomPacketPayload {
+public record SkinShuffleHandshakePayload() {
 
     public static final SkinShuffleHandshakePayload INSTANCE = new SkinShuffleHandshakePayload();
 
     public static final ResourceLocation PACKET_ID = SkinShuffleCompatibility.resourceLocation("handshake");
-
-    @Override
-    public void write(@NotNull FriendlyByteBuf buf) {
-        // NO-OP
-    }
-    
-    @Override
-    public @NotNull ResourceLocation id() {
-        return PACKET_ID;
-    }
 }

common/src/main/java/net/lionarius/skinrestorer/compat/skinshuffle/SkinShuffleSkinRefreshV1Payload.java

@@ -2,34 +2,22 @@ package net.lionarius.skinrestorer.compat.skinshuffle;
 
 import com.mojang.authlib.properties.Property;
 import net.minecraft.network.FriendlyByteBuf;
-import net.minecraft.network.protocol.common.custom.CustomPacketPayload;
 import net.minecraft.resources.ResourceLocation;
-import org.jetbrains.annotations.NotNull;
 
 public record SkinShuffleSkinRefreshV1Payload(
-        Property textureProperty) implements CustomPacketPayload, SkinShuffleSkinRefreshPayload {
+        Property textureProperty) implements SkinShuffleSkinRefreshPayload {
     
     public static final ResourceLocation PACKET_ID = SkinShuffleCompatibility.resourceLocation("refresh");
     
     public static void encode(FriendlyByteBuf buf, SkinShuffleSkinRefreshV1Payload value) {
         var textureProperty = value.textureProperty();
         
-        buf.writeUtf(textureProperty.name());
-        buf.writeUtf(textureProperty.value());
-        buf.writeNullable(textureProperty.signature(), FriendlyByteBuf::writeUtf);
+        buf.writeUtf(textureProperty.getName());
+        buf.writeUtf(textureProperty.getValue());
+        buf.writeNullable(textureProperty.getSignature(), FriendlyByteBuf::writeUtf);
     }
     
     public static SkinShuffleSkinRefreshV1Payload decode(FriendlyByteBuf buf) {
         return new SkinShuffleSkinRefreshV1Payload(new Property(buf.readUtf(), buf.readUtf(), buf.readNullable(FriendlyByteBuf::readUtf)));
     }
-    
-    @Override
-    public void write(@NotNull FriendlyByteBuf buf) {
-        encode(buf, this);
-    }
-    
-    @Override
-    public @NotNull ResourceLocation id() {
-        return PACKET_ID;
-    }
 }

common/src/main/java/net/lionarius/skinrestorer/compat/skinshuffle/SkinShuffleSkinRefreshV2Payload.java

@@ -2,12 +2,10 @@ package net.lionarius.skinrestorer.compat.skinshuffle;
 
 import com.mojang.authlib.properties.Property;
 import net.minecraft.network.FriendlyByteBuf;
-import net.minecraft.network.protocol.common.custom.CustomPacketPayload;
 import net.minecraft.resources.ResourceLocation;
-import org.jetbrains.annotations.NotNull;
 
 public record SkinShuffleSkinRefreshV2Payload(
-        Property textureProperty) implements CustomPacketPayload, SkinShuffleSkinRefreshPayload {
+        Property textureProperty) implements SkinShuffleSkinRefreshPayload {
     
     public static final ResourceLocation PACKET_ID = SkinShuffleCompatibility.resourceLocation("skin_refresh");
 
@@ -15,12 +13,12 @@ public record SkinShuffleSkinRefreshV2Payload(
         var textureProperty = value.textureProperty();
         
         buf.writeBoolean(textureProperty.hasSignature());
-        buf.writeUtf(textureProperty.name());
-        buf.writeUtf(textureProperty.value());
+        buf.writeUtf(textureProperty.getName());
+        buf.writeUtf(textureProperty.getValue());
         if (textureProperty.hasSignature()) {
-            assert textureProperty.signature() != null;
+            assert textureProperty.getSignature() != null;
             
-            buf.writeUtf(textureProperty.signature());
+            buf.writeUtf(textureProperty.getSignature());
         }
     }
 
@@ -30,14 +28,4 @@ public record SkinShuffleSkinRefreshV2Payload(
         }
         return new SkinShuffleSkinRefreshV2Payload(new Property(buf.readUtf(), buf.readUtf(), null));
     }
-    
-    @Override
-    public void write(@NotNull FriendlyByteBuf buf) {
-        encode(buf, this);
-    }
-    
-    @Override
-    public @NotNull ResourceLocation id() {
-        return PACKET_ID;
-    }
 }

common/src/main/java/net/lionarius/skinrestorer/config/Config.java

@@ -22,8 +22,6 @@ public final class Config implements GsonPostProcessable {
     
     private boolean fetchSkinOnFirstJoin = true;
     
-    private boolean forceFirstJoinSkinFetch = false;
-    
     private FirstJoinSkinProvider firstJoinSkinProvider = FirstJoinSkinProvider.MOJANG;
     
     private String proxy = "";
@@ -49,10 +47,6 @@ public final class Config implements GsonPostProcessable {
         return this.fetchSkinOnFirstJoin;
     }
     
-    public boolean forceFirstJoinSkinFetch() {
-        return this.forceFirstJoinSkinFetch;
-    }
-    
     public FirstJoinSkinProvider firstJoinSkinProvider() {
         return this.firstJoinSkinProvider;
     }

common/src/main/java/net/lionarius/skinrestorer/config/FirstJoinSkinProvider.java

@@ -1,7 +1,6 @@
 package net.lionarius.skinrestorer.config;
 
 import com.google.gson.annotations.SerializedName;
-import net.lionarius.skinrestorer.skin.provider.CollectionSkinProvider;
 import net.lionarius.skinrestorer.skin.provider.ElyBySkinProvider;
 import net.lionarius.skinrestorer.skin.provider.MojangSkinProvider;
 
@@ -9,9 +8,7 @@ public enum FirstJoinSkinProvider {
     @SerializedName(value = "MOJANG", alternate = {"mojang"})
     MOJANG(MojangSkinProvider.PROVIDER_NAME),
     @SerializedName(value = "ELY.BY", alternate = {"ely.by", "ELY_BY", "ely_by"})
-    ELY_BY(ElyBySkinProvider.PROVIDER_NAME),
-    @SerializedName(value = "COLLECTION", alternate = {"collection"})
-    COLLECTION(CollectionSkinProvider.PROVIDER_NAME);
+    ELY_BY(ElyBySkinProvider.PROVIDER_NAME);
     
     private final String name;
     

common/src/main/java/net/lionarius/skinrestorer/config/provider/BuiltInProviderConfig.java

@@ -8,13 +8,8 @@ public abstract class BuiltInProviderConfig implements GsonPostProcessable {
     protected String name;
     protected CacheConfig cache;
     
-    
     public BuiltInProviderConfig(String name, CacheConfig cache) {
-        this(name, cache, true);
-    }
-    
-    public BuiltInProviderConfig(String name, CacheConfig cache, boolean enabled) {
-        this.enabled = enabled;
+        this.enabled = true;
         this.name = name;
         this.cache = cache;
     }

common/src/main/java/net/lionarius/skinrestorer/config/provider/CacheConfig.java

@@ -5,20 +5,20 @@ import net.lionarius.skinrestorer.SkinRestorer;
 public final class CacheConfig {
     private boolean enabled;
     private long duration;
-    
+
     public CacheConfig(boolean enabled, long duration) {
         this.enabled = enabled;
         this.duration = duration;
     }
-    
+
     public boolean enabled() {
         return enabled;
     }
-    
+
     public long duration() {
         return duration;
     }
-    
+
     void validate(CacheConfig defaultValue) {
         if (this.duration <= 0) {
             SkinRestorer.LOGGER.warn("Cache duration is less than or equal to zero, defaulting to {}", defaultValue.duration());

common/src/main/java/net/lionarius/skinrestorer/config/provider/ProvidersConfig.java

@@ -1,65 +1,52 @@
 package net.lionarius.skinrestorer.config.provider;
 
 import net.lionarius.skinrestorer.SkinRestorer;
-import net.lionarius.skinrestorer.config.provider.collection.CollectionProviderConfig;
 import net.lionarius.skinrestorer.util.gson.GsonPostProcessable;
 
 public final class ProvidersConfig implements GsonPostProcessable {
     public static final ProvidersConfig DEFAULT = new ProvidersConfig(
             new MojangProviderConfig(),
             new ElyByProviderConfig(),
-            new MineskinProviderConfig(),
-            new CollectionProviderConfig()
+            new MineskinProviderConfig()
     );
-    
+
     private MojangProviderConfig mojang;
     private ElyByProviderConfig ely_by;
     private MineskinProviderConfig mineskin;
-    private CollectionProviderConfig collection;
-    
-    public ProvidersConfig(MojangProviderConfig mojang, ElyByProviderConfig ely_by, MineskinProviderConfig mineskin, CollectionProviderConfig collection) {
+
+    public ProvidersConfig(MojangProviderConfig mojang, ElyByProviderConfig ely_by, MineskinProviderConfig mineskin) {
         this.mojang = mojang;
         this.ely_by = ely_by;
         this.mineskin = mineskin;
-        this.collection = collection;
     }
-    
+
     public MojangProviderConfig mojang() {
         return this.mojang;
     }
-    
+
     public ElyByProviderConfig ely_by() {
         return this.ely_by;
     }
-    
+
     public MineskinProviderConfig mineskin() {
         return this.mineskin;
     }
-    
-    public CollectionProviderConfig collection() {
-        return this.collection;
-    }
-    
+
     @Override
     public void gsonPostProcess() {
         if (this.mojang == null) {
             SkinRestorer.LOGGER.warn("Mojang provider config is null, using default");
             this.mojang = ProvidersConfig.DEFAULT.mojang();
         }
-        
+
         if (this.ely_by == null) {
             SkinRestorer.LOGGER.warn("Ely.By provider config is null, using default");
             this.ely_by = ProvidersConfig.DEFAULT.ely_by();
         }
-        
+
         if (this.mineskin == null) {
             SkinRestorer.LOGGER.warn("Mineskin provider config is null, using default");
             this.mineskin = ProvidersConfig.DEFAULT.mineskin();
         }
-        
-        if (this.collection == null) {
-            SkinRestorer.LOGGER.warn("Collection provider config is null, using default");
-            this.collection = ProvidersConfig.DEFAULT.collection();
-        }
     }
 }

common/src/main/java/net/lionarius/skinrestorer/config/provider/collection/CollectionProviderConfig.java

@@ -1,32 +0,0 @@
-package net.lionarius.skinrestorer.config.provider.collection;
-
-import com.google.gson.annotations.JsonAdapter;
-import net.lionarius.skinrestorer.config.provider.BuiltInProviderConfig;
-import net.lionarius.skinrestorer.config.provider.CacheConfig;
-import net.lionarius.skinrestorer.skin.provider.CollectionSkinProvider;
-import net.lionarius.skinrestorer.util.gson.GsonPostProcessable;
-
-import java.util.ArrayList;
-import java.util.List;
-
-public final class CollectionProviderConfig extends BuiltInProviderConfig implements GsonPostProcessable {
-    private static final CacheConfig DEFAULT_CACHE_VALUE = new CacheConfig(true, 604800);
-    
-    @JsonAdapter(CollectionSkinSourceListDeserializer.class)
-    private List<CollectionSkinSource> sources = new ArrayList<>();
-    
-    public CollectionProviderConfig() {
-        super(CollectionSkinProvider.PROVIDER_NAME, DEFAULT_CACHE_VALUE, false);
-    }
-    
-    public List<CollectionSkinSource> sources() {
-        return this.sources;
-    }
-    
-    @Override
-    public void gsonPostProcess() {
-        if (this.sources == null) {
-            this.sources = new ArrayList<>();
-        }
-    }
-}

common/src/main/java/net/lionarius/skinrestorer/config/provider/collection/CollectionSkinFile.java

@@ -1,60 +0,0 @@
-package net.lionarius.skinrestorer.config.provider.collection;
-
-import net.lionarius.skinrestorer.SkinRestorer;
-import net.lionarius.skinrestorer.skin.SkinVariant;
-import net.lionarius.skinrestorer.util.gson.GsonPostProcessable;
-import org.jetbrains.annotations.Nullable;
-
-import java.net.URI;
-import java.nio.file.Files;
-import java.nio.file.Path;
-
-public final class CollectionSkinFile implements CollectionSkinSource, GsonPostProcessable {
-    private String path = "";
-    private SkinVariant variant = SkinVariant.CLASSIC;
-    
-    @Override
-    public @Nullable URI uri() {
-        if (this.path.isEmpty())
-            return null;
-        
-        try {
-            var filePath = SkinRestorer.getConfigDir().resolve(this.path);
-            
-            if (!Files.exists(filePath)) {
-                SkinRestorer.LOGGER.warn("Skin file does not exist: {}", this.path);
-                return null;
-            }
-            
-            if (!Files.isRegularFile(filePath)) {
-                SkinRestorer.LOGGER.warn("Skin path is not a file: {}", this.path);
-                return null;
-            }
-            
-            if (!this.path.toLowerCase().endsWith(".png")) {
-                SkinRestorer.LOGGER.warn("Skin file is not a PNG file: {}", this.path);
-                return null;
-            }
-            
-            return filePath.toUri();
-        } catch (Exception e) {
-            SkinRestorer.LOGGER.warn("Invalid file path: {}", this.path, e);
-            return null;
-        }
-    }
-    
-    @Override
-    public SkinVariant variant() {
-        return this.variant;
-    }
-    
-    @Override
-    public void gsonPostProcess() {
-        if (this.path == null) {
-            this.path = "";
-        }
-        if (this.variant == null) {
-            this.variant = SkinVariant.CLASSIC;
-        }
-    }
-}

common/src/main/java/net/lionarius/skinrestorer/config/provider/collection/CollectionSkinSource.java

@@ -1,12 +0,0 @@
-package net.lionarius.skinrestorer.config.provider.collection;
-
-import net.lionarius.skinrestorer.skin.SkinVariant;
-import org.jetbrains.annotations.Nullable;
-
-import java.net.URI;
-
-public interface CollectionSkinSource {
-    @Nullable URI uri();
-    
-    SkinVariant variant();
-}

common/src/main/java/net/lionarius/skinrestorer/config/provider/collection/CollectionSkinSourceListDeserializer.java

@@ -1,35 +0,0 @@
-package net.lionarius.skinrestorer.config.provider.collection;
-
-import com.google.gson.*;
-
-import java.lang.reflect.Type;
-import java.util.ArrayList;
-import java.util.List;
-
-public class CollectionSkinSourceListDeserializer implements JsonSerializer<List<CollectionSkinSource>>, JsonDeserializer<List<CollectionSkinSource>> {
-    @Override
-    public JsonElement serialize(List<CollectionSkinSource> src, Type typeOfT, JsonSerializationContext context) {
-        return context.serialize(src, List.class);
-    }
-    
-    @Override
-    public List<CollectionSkinSource> deserialize(JsonElement json, Type typeOfT, JsonDeserializationContext context)
-            throws JsonParseException {
-        List<CollectionSkinSource> sources = new ArrayList<>();
-        
-        if (json.isJsonArray()) {
-            for (JsonElement element : json.getAsJsonArray()) {
-                if (element.isJsonObject()) {
-                    JsonObject obj = element.getAsJsonObject();
-                    if (obj.has("url")) {
-                        sources.add(context.deserialize(obj, CollectionSkinUrl.class));
-                    } else if (obj.has("path")) {
-                        sources.add(context.deserialize(obj, CollectionSkinFile.class));
-                    }
-                }
-            }
-        }
-        
-        return sources;
-    }
-}

common/src/main/java/net/lionarius/skinrestorer/config/provider/collection/CollectionSkinUrl.java

@@ -1,41 +0,0 @@
-package net.lionarius.skinrestorer.config.provider.collection;
-
-import net.lionarius.skinrestorer.SkinRestorer;
-import net.lionarius.skinrestorer.skin.SkinVariant;
-import net.lionarius.skinrestorer.util.gson.GsonPostProcessable;
-import org.jetbrains.annotations.Nullable;
-
-import java.net.URI;
-
-public final class CollectionSkinUrl implements CollectionSkinSource, GsonPostProcessable {
-    private String url = "";
-    private SkinVariant variant = SkinVariant.CLASSIC;
-    
-    @Override
-    public @Nullable URI uri() {
-        try {
-            if (this.url.isEmpty())
-                return null;
-            
-            return new URI(this.url);
-        } catch (Exception e) {
-            SkinRestorer.LOGGER.warn("Invalid URI: {}", this.url, e);
-            return null;
-        }
-    }
-    
-    @Override
-    public SkinVariant variant() {
-        return this.variant;
-    }
-    
-    @Override
-    public void gsonPostProcess() {
-        if (this.url == null) {
-            this.url = "";
-        }
-        if (this.variant == null) {
-            this.variant = SkinVariant.CLASSIC;
-        }
-    }
-}

common/src/main/java/net/lionarius/skinrestorer/exception/TransparentException.java

@@ -1,19 +0,0 @@
-package net.lionarius.skinrestorer.exception;
-
-import org.jetbrains.annotations.NotNull;
-
-public class TransparentException extends RuntimeException {
-    public TransparentException(@NotNull Throwable cause) {
-        super(cause);
-    }
-    
-    @Override
-    public String getMessage() {
-        return this.getCause().getMessage();
-    }
-    
-    @Override
-    public String toString() {
-        return this.getLocalizedMessage();
-    }
-}

common/src/main/java/net/lionarius/skinrestorer/mineskin/Java11RequestHandler.java

@@ -32,8 +32,8 @@ public class Java11RequestHandler extends RequestHandler {
     private final Gson gson;
     private final HttpClient httpClient;
     
-    public Java11RequestHandler(String baseUrl, String userAgent, String apiKey, int timeout, Gson gson, InetSocketAddress proxy) {
-        super(baseUrl, userAgent, apiKey, timeout, gson);
+    public Java11RequestHandler(String userAgent, String apiKey, int timeout, Gson gson, InetSocketAddress proxy) {
+        super(userAgent, apiKey, timeout, gson);
         this.gson = gson;
         
         HttpClient.Builder clientBuilder = HttpClient.newBuilder()
@@ -85,7 +85,6 @@ public class Java11RequestHandler extends RequestHandler {
     
     public <T, R extends MineSkinResponse<T>> R getJson(String url, Class<T> clazz, ResponseConstructor<T, R> constructor)
             throws IOException {
-        url = this.baseUrl + url;
         MineSkinClientImpl.LOGGER.fine("GET " + url);
         
         HttpRequest.Builder requestBuilder = HttpRequest.newBuilder()
@@ -111,7 +110,6 @@ public class Java11RequestHandler extends RequestHandler {
     
     public <T, R extends MineSkinResponse<T>> R postJson(String url, JsonObject data, Class<T> clazz, ResponseConstructor<T, R> constructor)
             throws IOException {
-        url = this.baseUrl + url;
         MineSkinClientImpl.LOGGER.fine("POST " + url);
         
         HttpRequest.Builder requestBuilder = HttpRequest.newBuilder()
@@ -139,7 +137,6 @@ public class Java11RequestHandler extends RequestHandler {
     
     public <T, R extends MineSkinResponse<T>> R postFormDataFile(String url, String key, String filename, InputStream in, Map<String, String> data, Class<T> clazz, ResponseConstructor<T, R> constructor)
             throws IOException {
-        url = this.baseUrl + url;
         MineSkinClientImpl.LOGGER.fine("POST " + url);
         
         String boundary = "mineskin-" + System.currentTimeMillis();

common/src/main/java/net/lionarius/skinrestorer/mixin/ChunkMapAccessor.java

@@ -9,5 +9,5 @@ import org.spongepowered.asm.mixin.gen.Accessor;
 public interface ChunkMapAccessor {
     
     @Accessor
-    Int2ObjectMap<TrackedEntityAccessorInvoker> getEntityMap();
+    Int2ObjectMap<Object> getEntityMap();
 }

common/src/main/java/net/lionarius/skinrestorer/mixin/GameProfileCacheAccessor.java

@@ -1,14 +0,0 @@
-package net.lionarius.skinrestorer.mixin;
-
-import net.minecraft.server.players.GameProfileCache;
-import org.spongepowered.asm.mixin.Mixin;
-import org.spongepowered.asm.mixin.gen.Accessor;
-
-import java.util.Map;
-
-@Mixin(GameProfileCache.class)
-public interface GameProfileCacheAccessor {
-    
-    @Accessor
-    Map<String, GameProfileCache.GameProfileInfo> getProfilesByName();
-}

common/src/main/java/net/lionarius/skinrestorer/mixin/PlayerListMixin.java

@@ -4,28 +4,18 @@ import net.lionarius.skinrestorer.SkinRestorer;
 import net.minecraft.network.Connection;
 import net.minecraft.server.MinecraftServer;
 import net.minecraft.server.level.ServerPlayer;
-import net.minecraft.server.network.CommonListenerCookie;
 import net.minecraft.server.players.PlayerList;
-import org.spongepowered.asm.mixin.Final;
 import org.spongepowered.asm.mixin.Mixin;
-import org.spongepowered.asm.mixin.Shadow;
 import org.spongepowered.asm.mixin.Unique;
 import org.spongepowered.asm.mixin.injection.At;
 import org.spongepowered.asm.mixin.injection.Inject;
 import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
 
 import java.util.Collections;
-import java.util.List;
 
 @Mixin(PlayerList.class)
 public abstract class PlayerListMixin {
     
-    @Shadow
-    public abstract List<ServerPlayer> getPlayers();
-    
-    @Shadow @Final
-    private MinecraftServer server;
-    
     @Inject(method = "remove", at = @At("TAIL"))
     private void remove(ServerPlayer player, CallbackInfo ci) {
         SkinRestorer.Events.onPlayerDisconnect(player);
@@ -33,13 +23,14 @@ public abstract class PlayerListMixin {
     
     @Inject(method = "removeAll", at = @At("HEAD"))
     private void removeAll(CallbackInfo ci) {
-        for (var player : getPlayers()) {
+        for (var player : ((PlayerList) (Object) this).getPlayers()) {
             SkinRestorer.Events.onPlayerDisconnect(player);
         }
     }
     
     @Inject(method = "placeNewPlayer", at = @At("HEAD"))
-    private void placeNewPlayer(Connection connection, ServerPlayer player, CommonListenerCookie cookie, CallbackInfo ci) {
+    private void placeNewPlayer(Connection connection, ServerPlayer player, CallbackInfo ci) {
+        var server = ((PlayerList) (Object) this).getServer();
         var delay = SkinRestorer.getConfig().skinApplyDelayOnJoin();
         
         if (delay <= 0) {

common/src/main/java/net/lionarius/skinrestorer/mixin/ServerLoginPacketListenerImplAccessorInvoker.java

@@ -0,0 +1,17 @@
+package net.lionarius.skinrestorer.mixin;
+
+import com.mojang.authlib.GameProfile;
+import net.minecraft.server.network.ServerLoginPacketListenerImpl;
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.gen.Accessor;
+import org.spongepowered.asm.mixin.gen.Invoker;
+
+@Mixin(ServerLoginPacketListenerImpl.class)
+public interface ServerLoginPacketListenerImplAccessorInvoker {
+    
+    @Accessor
+    GameProfile getGameProfile();
+    
+    @Invoker
+    GameProfile invokeCreateFakeProfile(GameProfile original);
+}

common/src/main/java/net/lionarius/skinrestorer/mixin/ServerLoginPacketListenerImplMixin.java

@@ -2,7 +2,6 @@ package net.lionarius.skinrestorer.mixin;
 
 import com.mojang.authlib.GameProfile;
 import net.lionarius.skinrestorer.SkinRestorer;
-import net.lionarius.skinrestorer.config.FirstJoinSkinProvider;
 import net.lionarius.skinrestorer.skin.SkinValue;
 import net.lionarius.skinrestorer.skin.provider.SkinProviderContext;
 import net.lionarius.skinrestorer.util.PlayerUtils;
@@ -21,21 +20,19 @@ import java.util.concurrent.CompletableFuture;
 @Mixin(ServerLoginPacketListenerImpl.class)
 public abstract class ServerLoginPacketListenerImplMixin {
     
-    @Shadow @Nullable
-    private GameProfile authenticatedProfile;
-    
     @Unique
     private CompletableFuture<Void> skinrestorer$pendingSkin;
     
-    @Inject(method = "verifyLoginAndFinishConnectionSetup", at = @At(value = "INVOKE",
-                                                                     target = "Lnet/minecraft/server/players/PlayerList;canPlayerLogin(Ljava/net/SocketAddress;Lcom/mojang/authlib/GameProfile;)Lnet/minecraft/network/chat/Component;"),
-            cancellable = true)
+    @Inject(method = "handleAcceptedLogin", at = @At(value = "HEAD"), cancellable = true)
     public void waitForSkin(CallbackInfo ci) {
         if (skinrestorer$pendingSkin == null) {
             skinrestorer$pendingSkin = CompletableFuture.supplyAsync(() -> {
-                final var profile = authenticatedProfile;
-                
+                var profile = ((ServerLoginPacketListenerImplAccessorInvoker) this).getGameProfile();
                 assert profile != null;
+                
+                if (!profile.isComplete())
+                    profile = ((ServerLoginPacketListenerImplAccessorInvoker) this).invokeCreateFakeProfile(profile);
+                
                 var originalSkin = PlayerUtils.getPlayerSkin(profile);
                 
                 if (SkinRestorer.getSkinStorage().hasSavedSkin(profile.getId())) {
@@ -54,15 +51,9 @@ public abstract class ServerLoginPacketListenerImplMixin {
                     return null;
                 }
                 
-                var config = SkinRestorer.getConfig();
-                var provider = config.firstJoinSkinProvider();
-                
-                var shouldFetch = (originalSkin == null && config.fetchSkinOnFirstJoin()) ||
-                                      (originalSkin != null && config.forceFirstJoinSkinFetch() && provider != FirstJoinSkinProvider.MOJANG);
-                
-                if (shouldFetch) {
+                if (originalSkin == null && SkinRestorer.getConfig().fetchSkinOnFirstJoin()) {
                     var context = new SkinProviderContext(
-                            provider.getName(),
+                            SkinRestorer.getConfig().firstJoinSkinProvider().getName(),
                             profile.getName(),
                             null
                     );
@@ -89,7 +80,7 @@ public abstract class ServerLoginPacketListenerImplMixin {
             var value = SkinValue.fromProviderContextWithValue(context, result.getSuccessValue().orElse(null));
             SkinRestorer.getSkinStorage().setSkin(profile.getId(), value);
         } else {
-            SkinRestorer.LOGGER.warn("Failed to fetch skin '{}:{}'", context.name(), context.argument(), result.getErrorValue());
+            SkinRestorer.LOGGER.warn("Failed to fetch skin: {}", result.getErrorValue().getMessage());
         }
     }
 }

common/src/main/java/net/lionarius/skinrestorer/mixin/SkullBlockEntityMixin.java

@@ -1,58 +0,0 @@
-package net.lionarius.skinrestorer.mixin;
-
-import com.mojang.authlib.GameProfile;
-import net.lionarius.skinrestorer.SkinRestorer;
-import net.lionarius.skinrestorer.util.PlayerUtils;
-import net.minecraft.Util;
-import net.minecraft.server.Services;
-import net.minecraft.world.level.block.entity.SkullBlockEntity;
-import org.spongepowered.asm.mixin.Mixin;
-import org.spongepowered.asm.mixin.Unique;
-import org.spongepowered.asm.mixin.injection.At;
-import org.spongepowered.asm.mixin.injection.Inject;
-import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
-
-import java.util.Locale;
-import java.util.Optional;
-import java.util.UUID;
-import java.util.concurrent.CompletableFuture;
-import java.util.function.BooleanSupplier;
-
-@Mixin(SkullBlockEntity.class)
-public abstract class SkullBlockEntityMixin {
-    
-    @Inject(method = "loadProfile", at = @At("HEAD"),
-            cancellable = true)
-    private static void fetchProfileByName(String name, Services services, BooleanSupplier hasCache, CallbackInfoReturnable<CompletableFuture<Optional<GameProfile>>> cir) {
-        if (name == null)
-            return;
-        
-        var profileOpt = Optional.<GameProfile>empty();
-        var gameProfileInfo = ((GameProfileCacheAccessor) services.profileCache()).getProfilesByName().get(name.toLowerCase(Locale.ROOT));
-        
-        if (gameProfileInfo != null)
-            profileOpt = Optional.of(gameProfileInfo.getProfile());
-        
-        skinrestorer$replaceSkin(profileOpt, cir);
-    }
-    
-    @Unique
-    private static void skinrestorer$replaceSkin(Optional<GameProfile> profileOpt, CallbackInfoReturnable<CompletableFuture<Optional<GameProfile>>> cir) {
-        if (SkinRestorer.getMinecraftServer() == null)
-            return;
-        
-        if (profileOpt.isEmpty())
-            return;
-        
-        var profile = PlayerUtils.cloneGameProfile(profileOpt.get());
-        
-        if (SkinRestorer.getSkinStorage().hasSavedSkin(profile.getId())) {
-            cir.setReturnValue(CompletableFuture.supplyAsync(() -> {
-                var skin = SkinRestorer.getSkinStorage().getSkin(profile.getId(), false);
-                PlayerUtils.applyRestoredSkin(profile, skin.value());
-                
-                return Optional.of(profile);
-            }, Util.backgroundExecutor()));
-        }
-    }
-}

common/src/main/java/net/lionarius/skinrestorer/platform/Services.java

@@ -8,11 +8,11 @@ import java.util.ServiceLoader;
 
 public final class Services {
     
+    private Services() {}
+    
     public final static PlatformHelper PLATFORM = load(PlatformHelper.class);
     public final static CompatibilityHelper COMPATIBILITY = load(CompatibilityHelper.class);
     
-    private Services() {}
-    
     private static <T> T load(Class<T> clazz) {
         final T loadedService = ServiceLoader.load(clazz)
                 .findFirst()

common/src/main/java/net/lionarius/skinrestorer/skin/SkinStorage.java

@@ -17,22 +17,15 @@ public class SkinStorage {
         return this.skinMap.containsKey(uuid) || this.skinIO.skinExists(uuid);
     }
     
-    public SkinValue getSkin(UUID uuid, boolean cache) {
+    public SkinValue getSkin(UUID uuid) {
         if (!skinMap.containsKey(uuid)) {
             var skin = skinIO.loadSkin(uuid);
-            if (!cache)
-                return skin;
-            
             setSkin(uuid, skin);
         }
         
         return skinMap.get(uuid);
     }
     
-    public SkinValue getSkin(UUID uuid) {
-        return this.getSkin(uuid, true);
-    }
-    
     public void removeSkin(UUID uuid, boolean save) {
         var skin = skinMap.remove(uuid);
         if (skin != null && save)

common/src/main/java/net/lionarius/skinrestorer/skin/SkinVariant.java

@@ -1,11 +1,8 @@
 package net.lionarius.skinrestorer.skin;
 
-import com.google.gson.annotations.SerializedName;
-
 public enum SkinVariant {
-    @SerializedName(value = "classic", alternate = {"CLASSIC"})
+    
     CLASSIC("classic"),
-    @SerializedName(value = "slim", alternate = {"SLIM"})
     SLIM("slim");
     
     private final String name;

common/src/main/java/net/lionarius/skinrestorer/skin/provider/CollectionSkinProvider.java

@@ -1,91 +0,0 @@
-package net.lionarius.skinrestorer.skin.provider;
-
-import com.google.common.cache.CacheBuilder;
-import com.google.common.cache.CacheLoader;
-import com.google.common.cache.LoadingCache;
-import com.google.common.util.concurrent.UncheckedExecutionException;
-import com.mojang.authlib.properties.Property;
-import it.unimi.dsi.fastutil.Pair;
-import net.lionarius.skinrestorer.SkinRestorer;
-import net.lionarius.skinrestorer.config.provider.collection.CollectionSkinSource;
-import net.lionarius.skinrestorer.skin.SkinVariant;
-import net.lionarius.skinrestorer.util.Result;
-import org.jetbrains.annotations.NotNull;
-
-import java.net.URI;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Optional;
-import java.util.concurrent.TimeUnit;
-
-public final class CollectionSkinProvider implements SkinProvider {
-    
-    public static final String PROVIDER_NAME = "collection";
-    
-    private static LoadingCache<Integer, Optional<Property>> SKIN_CACHE;
-    
-    private static List<Pair<URI, SkinVariant>> COLLECTION_SKINS;
-    
-    public static void reload() {
-        COLLECTION_SKINS = loadCollectionSkins();
-        
-        createCache();
-    }
-    
-    private static List<Pair<URI, SkinVariant>> loadCollectionSkins() {
-        List<Pair<URI, SkinVariant>> skins = new ArrayList<>();
-        
-        var config = SkinRestorer.getConfig().providersConfig().collection();
-        
-        for (CollectionSkinSource source : config.sources()) {
-            var uri = source.uri();
-            if (uri != null) {
-                skins.add(Pair.of(uri, source.variant()));
-            }
-        }
-        
-        return skins;
-    }
-    
-    private static void createCache() {
-        var config = SkinRestorer.getConfig().providersConfig().collection();
-        var time = config.cache().enabled() ? config.cache().duration() : 0;
-        
-        SKIN_CACHE = CacheBuilder.newBuilder()
-                .expireAfterWrite(time, TimeUnit.SECONDS)
-                .build(new CacheLoader<>() {
-                    @Override
-                    public @NotNull Optional<Property> load(@NotNull Integer key) throws Exception {
-                        var skinEntry = COLLECTION_SKINS.get(key);
-                        return MineskinSkinProvider.loadSkin(skinEntry.first(), skinEntry.second());
-                    }
-                });
-    }
-    
-    @Override
-    public String getArgumentName() {
-        return "seed";
-    }
-    
-    @Override
-    public boolean hasVariantSupport() {
-        return false;
-    }
-    
-    @Override
-    public Result<Optional<Property>, Exception> fetchSkin(String argument, SkinVariant variant) {
-        if (COLLECTION_SKINS.isEmpty()) {
-            return Result.error(new IllegalStateException("No collection skins configured"));
-        }
-        
-        var skinIndex = Math.abs(argument.hashCode()) % COLLECTION_SKINS.size();
-        
-        try {
-            return Result.success(SKIN_CACHE.get(skinIndex));
-        } catch (UncheckedExecutionException e) {
-            return Result.error((Exception) e.getCause());
-        } catch (Exception e) {
-            return Result.error(e);
-        }
-    }
-}

common/src/main/java/net/lionarius/skinrestorer/skin/provider/ElyBySkinProvider.java

@@ -102,6 +102,6 @@ public final class ElyBySkinProvider implements SkinProvider {
         if (response.statusCode() != 200)
             throw new IllegalArgumentException("no profile with name " + username);
         
-        return JsonUtils.fromJson(response.body(), MinecraftProfilePropertiesResponse.class).toProfile();
+        return PlayerUtils.toProfile(JsonUtils.fromJson(response.body(), MinecraftProfilePropertiesResponse.class));
     }
 }

common/src/main/java/net/lionarius/skinrestorer/skin/provider/MineskinSkinProvider.java

@@ -22,8 +22,6 @@ import org.mineskin.response.QueueResponse;
 
 import java.net.InetSocketAddress;
 import java.net.URI;
-import java.nio.file.Files;
-import java.nio.file.Path;
 import java.time.Duration;
 import java.util.Optional;
 import java.util.concurrent.TimeUnit;
@@ -45,8 +43,7 @@ public final class MineskinSkinProvider implements SkinProvider {
                 .userAgent(WebUtils.USER_AGENT)
                 .gson(JsonUtils.GSON)
                 .timeout((int) Duration.ofSeconds(config.requestTimeout()).toMillis())
-                .requestHandler((baseUrl, userAgent, apiKey, timeout, gson) -> new Java11RequestHandler(
-                        baseUrl,
+                .requestHandler((userAgent, apiKey, timeout, gson) -> new Java11RequestHandler(
                         userAgent,
                         apiKey,
                         timeout,
@@ -96,18 +93,13 @@ public final class MineskinSkinProvider implements SkinProvider {
         }
     }
     
-    static Optional<Property> loadSkin(URI uri, SkinVariant variant) throws Exception {
+    private static Optional<Property> loadSkin(URI uri, SkinVariant variant) throws Exception {
         var mineskinVariant = switch (variant) {
             case CLASSIC -> Variant.CLASSIC;
             case SLIM -> Variant.SLIM;
         };
         
-        var request = "file".equals(uri.getScheme())
-                ? GenerateRequest.upload(Files.newInputStream(Path.of(uri)))
-                .variant(mineskinVariant)
-                .name("skinrestorer-skin")
-                .visibility(Visibility.UNLISTED)
-                : GenerateRequest.url(uri)
+        var request = GenerateRequest.url(uri)
                 .variant(mineskinVariant)
                 .name("skinrestorer-skin")
                 .visibility(Visibility.UNLISTED);

common/src/main/java/net/lionarius/skinrestorer/skin/provider/MojangSkinProvider.java

@@ -8,9 +8,7 @@ import com.mojang.authlib.*;
 import com.mojang.authlib.properties.Property;
 import com.mojang.authlib.yggdrasil.YggdrasilEnvironment;
 import com.mojang.authlib.yggdrasil.response.MinecraftProfilePropertiesResponse;
-import com.mojang.util.UndashedUuid;
 import net.lionarius.skinrestorer.SkinRestorer;
-import net.lionarius.skinrestorer.exception.TransparentException;
 import net.lionarius.skinrestorer.skin.SkinVariant;
 import net.lionarius.skinrestorer.util.*;
 import net.minecraft.server.players.GameProfileCache;
@@ -41,19 +39,19 @@ public final class MojangSkinProvider implements SkinProvider {
         try {
             ENVIRONMENT = EnvironmentParser.getEnvironmentFromProperties().orElse(YggdrasilEnvironment.PROD.getEnvironment());
             
-            SERVICES_SERVER_URI = new URI(ENVIRONMENT.servicesHost());
-            SESSION_SERVER_URI = new URI(ENVIRONMENT.sessionHost());
+            SERVICES_SERVER_URI = new URI(ENVIRONMENT.getServicesHost());
+            SESSION_SERVER_URI = new URI(ENVIRONMENT.getSessionHost());
         } catch (URISyntaxException e) {
             throw new IllegalArgumentException(e);
         }
         
-        PROFILE_CACHE = new GameProfileCache((names, callback) -> {
+        PROFILE_CACHE = new GameProfileCache((names, agent, callback) -> {
             for (var name : names) {
                 try {
                     var profile = MojangSkinProvider.getProfile(name);
                     callback.onProfileLookupSucceeded(profile);
                 } catch (IOException e) {
-                    throw new TransparentException(e);
+                    callback.onProfileLookupFailed(new GameProfile(null, name), e);
                 }
             }
         }, SkinRestorer.getConfigDir().resolve(PROFILE_CACHE_FILENAME).toFile());
@@ -138,7 +136,7 @@ public final class MojangSkinProvider implements SkinProvider {
         var request = HttpRequest.newBuilder()
                 .uri(MojangSkinProvider.SESSION_SERVER_URI
                         .resolve("/session/minecraft/profile/")
-                        .resolve(UndashedUuid.toString(uuid) + "?unsigned=false")
+                        .resolve(uuid.toString() + "?unsigned=false")
                 )
                 .GET()
                 .build();
@@ -149,6 +147,6 @@ public final class MojangSkinProvider implements SkinProvider {
         if (response.statusCode() != 200)
             throw new IllegalArgumentException("no profile with uuid " + uuid);
         
-        return JsonUtils.fromJson(response.body(), MinecraftProfilePropertiesResponse.class).toProfile();
+        return PlayerUtils.toProfile(JsonUtils.fromJson(response.body(), MinecraftProfilePropertiesResponse.class));
     }
 }

common/src/main/java/net/lionarius/skinrestorer/skin/provider/SkinProvider.java

@@ -13,7 +13,6 @@ public interface SkinProvider {
     MojangSkinProvider MOJANG = new MojangSkinProvider();
     ElyBySkinProvider ELY_BY = new ElyBySkinProvider();
     MineskinSkinProvider MINESKIN = new MineskinSkinProvider();
-    CollectionSkinProvider COLLECTION = new CollectionSkinProvider();
     SkinShuffleSkinProvider SKIN_SHUFFLE = new SkinShuffleSkinProvider();
     
     Set<String> BUILTIN_PROVIDER_NAMES = ImmutableSet.of(
@@ -21,7 +20,6 @@ public interface SkinProvider {
             MojangSkinProvider.PROVIDER_NAME,
             ElyBySkinProvider.PROVIDER_NAME,
             MineskinSkinProvider.PROVIDER_NAME,
-            CollectionSkinProvider.PROVIDER_NAME,
             SkinShuffleSkinProvider.PROVIDER_NAME
     );
     

common/src/main/java/net/lionarius/skinrestorer/util/JsonUtils.java

@@ -50,7 +50,7 @@ public final class JsonUtils {
     
     public static JsonObject skinPropertyToJson(Property property) {
         try {
-            JsonObject json = GSON.fromJson(new String(Base64.getDecoder().decode(property.value()), StandardCharsets.UTF_8), JsonObject.class);
+            JsonObject json = GSON.fromJson(new String(Base64.getDecoder().decode(property.getValue()), StandardCharsets.UTF_8), JsonObject.class);
             if (json != null)
                 json.remove("timestamp");
             

common/src/main/java/net/lionarius/skinrestorer/util/PlayerUtils.java

@@ -6,12 +6,14 @@ import com.mojang.authlib.GameProfile;
 import com.mojang.authlib.properties.Property;
 import com.mojang.authlib.yggdrasil.response.MinecraftProfilePropertiesResponse;
 import net.lionarius.skinrestorer.mixin.ChunkMapAccessor;
+import net.lionarius.skinrestorer.mixin.TrackedEntityAccessorInvoker;
 import net.minecraft.network.chat.Component;
 import net.minecraft.network.protocol.game.*;
 import net.minecraft.server.level.ChunkMap;
 import net.minecraft.server.level.ServerLevel;
 import net.minecraft.server.level.ServerPlayer;
 import net.minecraft.server.players.PlayerList;
+import net.minecraft.world.level.biome.BiomeManager;
 
 import java.util.*;
 
@@ -49,14 +51,14 @@ public final class PlayerUtils {
                 )
         ));
         
-        var trackedEntity = ((ChunkMapAccessor) chunkMap).getEntityMap().get(player.getId());
+        var trackedEntity = (TrackedEntityAccessorInvoker) ((ChunkMapAccessor) chunkMap).getEntityMap().get(player.getId());
         if (trackedEntity != null) {
             var seenBy = Set.copyOf(trackedEntity.getSeenBy());
             for (var observerConnection : seenBy) {
                 var observer = observerConnection.getPlayer();
                 trackedEntity.invokeRemovePlayer(observer);
                 
-                var trackedObserverEntity = ((ChunkMapAccessor) chunkMap).getEntityMap().get(observer.getId());
+                var trackedObserverEntity = (TrackedEntityAccessorInvoker) ((ChunkMapAccessor) chunkMap).getEntityMap().get(observer.getId());
                 if (trackedObserverEntity != null) {
                     trackedObserverEntity.invokeRemovePlayer(player);
                     trackedObserverEntity.invokeUpdatePlayer(player);
@@ -66,12 +68,20 @@ public final class PlayerUtils {
         }
         
         if (!player.isDeadOrDying()) {
-            player.connection.send(new ClientboundBundlePacket(
-                    List.of(
-                            new ClientboundRespawnPacket(player.createCommonSpawnInfo(serverLevel), ClientboundRespawnPacket.KEEP_ALL_DATA),
-                            new ClientboundGameEventPacket(ClientboundGameEventPacket.LEVEL_CHUNKS_LOAD_START, 0)
+            player.connection.send(
+                    new ClientboundRespawnPacket(
+                            player.level().dimensionTypeId(),
+                            player.level().dimension(),
+                            BiomeManager.obfuscateSeed(player.serverLevel().getSeed()),
+                            player.gameMode.getGameModeForPlayer(),
+                            player.gameMode.getPreviousGameModeForPlayer(),
+                            player.level().isDebug(),
+                            player.serverLevel().isFlat(),
+                            (byte) 3,
+                            player.getLastDeathLocation(),
+                            player.getPortalCooldown()
                     )
-            ));
+            );
             player.connection.teleport(player.getX(), player.getY(), player.getZ(), player.getYRot(), player.getXRot());
             player.connection.send(new ClientboundSetEntityMotionPacket(player));
             var vehicle = player.getVehicle();
@@ -95,13 +105,6 @@ public final class PlayerUtils {
         }
     }
     
-    public static GameProfile cloneGameProfile(GameProfile profile) {
-        var newProfile = new GameProfile(profile.getId(), profile.getName());
-        newProfile.getProperties().putAll(profile.getProperties());
-        
-        return newProfile;
-    }
-    
     public static Property getPlayerSkin(GameProfile profile) {
         return Iterables.getFirst(profile.getProperties().get(TEXTURES_KEY), null);
     }
@@ -133,8 +136,8 @@ public final class PlayerUtils {
     }
     
     public static GameProfile toProfile(MinecraftProfilePropertiesResponse response) {
-        final GameProfile profile = new GameProfile(response.id(), response.name());
-        profile.getProperties().putAll(response.properties());
+        final GameProfile profile = new GameProfile(response.getId(), response.getName());
+        profile.getProperties().putAll(response.getProperties());
         return profile;
     }
 }

common/src/main/java/net/lionarius/skinrestorer/util/Result.java

@@ -19,18 +19,6 @@ public class Result<S, E> {
         this.errorValue = errorValue;
     }
     
-    public static <S, E> Result<S, E> success(@NotNull S successValue) {
-        return new Result<>(successValue, null);
-    }
-    
-    public static <S, E> Result<S, E> error(@NotNull E errorValue) {
-        return new Result<>(null, errorValue);
-    }
-    
-    public static <S, E> Result<Optional<S>, E> ofNullable(S successValue) {
-        return Result.success(Optional.ofNullable(successValue));
-    }
-    
     public S getSuccessValue() {
         return successValue;
     }
@@ -81,4 +69,16 @@ public class Result<S, E> {
     public int hashCode() {
         return Objects.hash(successValue, errorValue);
     }
+    
+    public static <S, E> Result<S, E> success(@NotNull S successValue) {
+        return new Result<>(successValue, null);
+    }
+    
+    public static <S, E> Result<S, E> error(@NotNull E errorValue) {
+        return new Result<>(null, errorValue);
+    }
+    
+    public static <S, E> Result<Optional<S>, E> ofNullable(S successValue) {
+        return Result.success(Optional.ofNullable(successValue));
+    }
 }

common/src/main/java/net/lionarius/skinrestorer/util/WebUtils.java

@@ -13,6 +13,8 @@ import java.time.temporal.ChronoUnit;
 
 public final class WebUtils {
     
+    private WebUtils() {}
+    
     public static final String USER_AGENT;
     
     private static HttpClient HTTP_CLIENT = null;
@@ -21,8 +23,6 @@ public final class WebUtils {
         USER_AGENT = String.format("SkinRestorer/%d", System.currentTimeMillis() % 65535);
     }
     
-    private WebUtils() {}
-    
     public static void recreateHttpClient() {
         HTTP_CLIENT = WebUtils.buildClient();
     }

common/src/main/resources/META-INF/accesstransformer.cfg

@@ -1 +0,0 @@
-public net.minecraft.server.players.GameProfileCache$GameProfileInfo

common/src/main/resources/skinrestorer.accesswidener

@@ -1,3 +0,0 @@
-accessWidener v2 named
-
-accessible class net/minecraft/server/players/GameProfileCache$GameProfileInfo

common/src/main/resources/skinrestorer.mixins.json

@@ -8,10 +8,9 @@
     "mixins": [
         "ChunkMapAccessor",
         "PlayerListMixin",
+        "ServerLoginPacketListenerImplAccessorInvoker",
         "ServerLoginPacketListenerImplMixin",
-        "TrackedEntityAccessorInvoker",
-        "SkullBlockEntityMixin",
-        "GameProfileCacheAccessor"
+        "TrackedEntityAccessorInvoker"
     ],
     "injectors": {
         "defaultRequire": 1

fabric/gradle.properties

@@ -1,6 +1,5 @@
 # Fabric, see https://fabricmc.net/develop/ for new versions
 fabric_loader_version=0.15.0
-fabric_api_version=0.91.1+1.20.3
+fabric_api_version=0.83.0+1.20
 
 optional_dependencies=fabric-api
-additional_modloaders=quilt

fabric/src/main/java/net/lionarius/skinrestorer/fabric/mixin/MinecraftServerMixin.java

@@ -11,14 +11,8 @@ import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
 public abstract class MinecraftServerMixin {
     
     @Inject(method = "runServer",
-            at = @At(value = "INVOKE", target = "Lnet/minecraft/Util;getNanos()J", ordinal = 0))
+            at = @At(value = "INVOKE", target = "Lnet/minecraft/Util;getMillis()J", ordinal = 0))
     private void onServerStarted(CallbackInfo ci) {
         SkinRestorer.Events.onServerStarted((MinecraftServer) (Object) this);
     }
-    
-    @Inject(method = "runServer",
-            at = @At(value = "INVOKE", target = "Lnet/minecraft/server/MinecraftServer;onServerExit()V"))
-    private void onServerStopped(CallbackInfo ci) {
-        SkinRestorer.Events.onServerStopped((MinecraftServer) (Object) this);
-    }
 }

fabric/src/main/resources/fabric.mod.json

@@ -24,7 +24,6 @@
         "${mod_id}.mixins.json",
         "${mod_id}.fabric.mixins.json"
     ],
-    "accessWidener": "${mod_id}.accesswidener",
     "depends": {
         "fabricloader": ">=${fabric_loader_version}",
         "minecraft": ">=${minecraft_version}",

forge/build.gradle

@@ -26,14 +26,14 @@ tasks.named('jarJar') {
 }
 
 minecraft {
-    mappings channel: 'parchment', version: "${parchment_minecraft}-${parchment_version}-${minecraft_version}"
+    mappings channel: 'parchment', version: "${parchment_version}-${parchment_minecraft}"
 
     copyIdeResources = true //Calls processResources when in dev
 
     // Automatically enable forge AccessTransformers if the file exists
     // This location is hardcoded in Forge and can not be changed.
     // https://github.com/MinecraftForge/MinecraftForge/blob/be1698bb1554f9c8fa2f58e32b9ab70bc4385e60/fmlloader/src/main/java/net/minecraftforge/fml/loading/moddiscovery/ModFile.java#L123
-    def at = project(":common").file('src/main/resources/META-INF/accesstransformer.cfg')
+    def at = project(':common').file('src/main/resources/META-INF/accesstransformer.cfg')
     if (at.exists()) {
         accessTransformer = at
     }
@@ -88,7 +88,3 @@ sourceSets.each {
     it.output.resourcesDir = dir
     it.java.destinationDirectory = dir
 }
-
-tasks.named('processResources') {
-    duplicatesStrategy = DuplicatesStrategy.INCLUDE
-}

forge/gradle.properties

@@ -1,5 +1,5 @@
 # Forge, see https://files.minecraftforge.net/net/minecraftforge/forge/ for new versions
-forge_version=49.0.1
-forge_loader_version_range=[49,)
+forge_version=46.0.1
+forge_loader_version_range=[46,)
 # Forge sometimes skips minor minecraft versions (like 1.20.5)
-forge_minecraft_version=1.20.3
+forge_minecraft_version=1.20

forge/src/main/java/net/lionarius/skinrestorer/forge/SkinRestorerForge.java

@@ -4,7 +4,6 @@ import net.lionarius.skinrestorer.SkinRestorer;
 import net.lionarius.skinrestorer.compat.skinshuffle.SkinShuffleCompatibility;
 import net.minecraftforge.event.RegisterCommandsEvent;
 import net.minecraftforge.event.server.ServerStartedEvent;
-import net.minecraftforge.event.server.ServerStoppedEvent;
 import net.minecraftforge.eventbus.api.SubscribeEvent;
 import net.minecraftforge.fml.common.Mod;
 
@@ -28,9 +27,4 @@ public final class SkinRestorerForge {
     public static void onServerStarted(ServerStartedEvent event) {
         SkinRestorer.Events.onServerStarted(event.getServer());
     }
-    
-    @SubscribeEvent
-    public static void onServerStopped(ServerStoppedEvent event) {
-        SkinRestorer.Events.onServerStopped(event.getServer());
-    }
 }

forge/src/main/java/net/lionarius/skinrestorer/forge/compat/skinshuffle/SkinShufflePacketHandler.java

@@ -1,58 +1,65 @@
 package net.lionarius.skinrestorer.forge.compat.skinshuffle;
 
 import io.netty.buffer.Unpooled;
-import net.lionarius.skinrestorer.compat.skinshuffle.*;
 import net.lionarius.skinrestorer.compat.skinshuffle.SkinShuffleCompatibility;
+import net.lionarius.skinrestorer.compat.skinshuffle.*;
 import net.minecraft.network.Connection;
 import net.minecraft.network.FriendlyByteBuf;
-import net.minecraftforge.event.network.CustomPayloadEvent;
-import net.minecraftforge.network.ChannelBuilder;
-import net.minecraftforge.network.EventNetworkChannel;
+import net.minecraft.network.protocol.game.ClientboundCustomPayloadPacket;
+import net.minecraftforge.network.NetworkEvent;
+import net.minecraftforge.network.NetworkRegistry;
+import net.minecraftforge.network.event.EventNetworkChannel;
 
 public class SkinShufflePacketHandler {
-
-    private static final EventNetworkChannel HANDSHAKE_INSTANCE = ChannelBuilder
-            .named(SkinShuffleHandshakePayload.PACKET_ID)
-            .optional()
-            .eventNetworkChannel();
-    
-    private static final EventNetworkChannel SKIN_REFRESH_V1_INSTANCE = ChannelBuilder
-            .named(SkinShuffleSkinRefreshV1Payload.PACKET_ID)
-            .optional()
-            .eventNetworkChannel()
-            .addListener(SkinShufflePacketHandler::skinRefreshV1Listener);
-    
-    private static final EventNetworkChannel SKIN_REFRESH_V2_INSTANCE = ChannelBuilder
-            .named(SkinShuffleSkinRefreshV2Payload.PACKET_ID)
-            .optional()
-            .eventNetworkChannel()
-            .addListener(SkinShufflePacketHandler::skinRefreshV2Listener);
-
-    protected static void initialize() {
-        // NO-OP
-    }
-    
     private SkinShufflePacketHandler() {
     }
-
-    public static void sendHandshake(Connection connection) {
-        HANDSHAKE_INSTANCE.send(new FriendlyByteBuf(Unpooled.buffer(0, 0)), connection);
+    
+    private static final EventNetworkChannel HANDSHAKE_INSTANCE = NetworkRegistry.ChannelBuilder
+            .named(SkinShuffleHandshakePayload.PACKET_ID)
+            .clientAcceptedVersions(NetworkRegistry.acceptMissingOr(""))
+            .serverAcceptedVersions(NetworkRegistry.acceptMissingOr(""))
+            .networkProtocolVersion(() -> "")
+            .eventNetworkChannel();
+    
+    private static final EventNetworkChannel SKIN_REFRESH_V1_INSTANCE = NetworkRegistry.ChannelBuilder
+            .named(SkinShuffleSkinRefreshV1Payload.PACKET_ID)
+            .clientAcceptedVersions(NetworkRegistry.acceptMissingOr(""))
+            .serverAcceptedVersions(NetworkRegistry.acceptMissingOr(""))
+            .networkProtocolVersion(() -> "")
+            .eventNetworkChannel();
+    
+    private static final EventNetworkChannel SKIN_REFRESH_V2_INSTANCE = NetworkRegistry.ChannelBuilder
+            .named(SkinShuffleSkinRefreshV2Payload.PACKET_ID)
+            .clientAcceptedVersions(NetworkRegistry.acceptMissingOr(""))
+            .serverAcceptedVersions(NetworkRegistry.acceptMissingOr(""))
+            .networkProtocolVersion(() -> "")
+            .eventNetworkChannel();
+    
+    protected static void initialize() {
+        SKIN_REFRESH_V1_INSTANCE.addListener(SkinShufflePacketHandler::skinRefreshV1Listener);
+        SKIN_REFRESH_V2_INSTANCE.addListener(SkinShufflePacketHandler::skinRefreshV2Listener);
     }
     
-    private static void skinRefreshV1Listener(CustomPayloadEvent event) {
+    public static void sendHandshake(Connection connection) {
+        connection.send(new ClientboundCustomPayloadPacket(SkinShuffleHandshakePayload.PACKET_ID, new FriendlyByteBuf(Unpooled.buffer(0, 0))));
+    }
+    
+    private static void skinRefreshV1Listener(NetworkEvent.ClientCustomPayloadEvent event) {
         var payload = SkinShuffleSkinRefreshV1Payload.decode(event.getPayload());
-        handleSkinRefreshPacket(payload, event.getSource());
+        handleSkinRefreshPacket(payload, event.getSource().get());
+        event.getSource().get().setPacketHandled(true);
     }
-
-    private static void skinRefreshV2Listener(CustomPayloadEvent event) {
+    
+    private static void skinRefreshV2Listener(NetworkEvent.ClientCustomPayloadEvent event) {
         var payload = SkinShuffleSkinRefreshV2Payload.decode(event.getPayload());
-        handleSkinRefreshPacket(payload, event.getSource());
+        handleSkinRefreshPacket(payload, event.getSource().get());
+        event.getSource().get().setPacketHandled(true);
     }
-
-    private static void handleSkinRefreshPacket(SkinShuffleSkinRefreshPayload payload, CustomPayloadEvent.Context context) {
+    
+    private static void handleSkinRefreshPacket(SkinShuffleSkinRefreshPayload payload, NetworkEvent.Context context) {
         var sender = context.getSender();
         
-        if (!context.isServerSide() || sender == null)
+        if (!context.getDirection().getReceptionSide().isServer() || sender == null)
             return;
         
         SkinShuffleCompatibility.handleSkinRefresh(sender.getServer(), sender, payload);

forge/src/main/java/net/lionarius/skinrestorer/forge/platform/ForgeCompatibilityHelper.java

@@ -8,6 +8,6 @@ public final class ForgeCompatibilityHelper implements CompatibilityHelper {
     
     @Override
     public void skinShuffle_sendHandshake(ServerPlayer player) {
-        SkinShufflePacketHandler.sendHandshake(player.connection.getConnection());
+        SkinShufflePacketHandler.sendHandshake(player.connection.connection);
     }
 }

gradle.properties

@@ -3,12 +3,12 @@ group=net.lionarius
 java_version=17
 
 # Common
-minecraft_version=1.20.3
-minecraft_version_list=1.20.3,1.20.4
-minecraft_version_range=[1.20.3,1.20.4]
+minecraft_version=1.20
+minecraft_version_list=1.20,1.20.1
+minecraft_version_range=[1.20, 1.20.1]
 mod_id=skinrestorer
 mod_name=SkinRestorer
-mod_version=2.5.0
+mod_version=2.3.2
 mod_author=Lionarius
 mod_homepage=https://modrinth.com/mod/skinrestorer
 mod_sources=https://github.com/Suiranoil/SkinRestorer
@@ -18,11 +18,11 @@ credits=
 description=A server-side mod for managing skins.
 
 # Dependencies
-mineskin_client_version=3.2.1-SNAPSHOT
+mineskin_client_version=3.0.1-SNAPSHOT
 
 # ParchmentMC mappings, see https://parchmentmc.org/docs/getting-started#choose-a-version for new versions
-parchment_minecraft=1.20.3
-parchment_version=2023.12.31
+parchment_minecraft=1.20.1
+parchment_version=2023.09.03
 
 # Publishing
 curseforge_id=443823

neoforge/build.gradle

@@ -12,9 +12,9 @@ neoForge {
     version = neoforge_version
     
     // Automatically enable neoforge AccessTransformers if the file exists
-    def at = project(":common").file('src/main/resources/META-INF/accesstransformer.cfg')
+    def at = project(':common').file('src/main/resources/META-INF/accesstransformer.cfg')
     if (at.exists()) {
-        accessTransformers.from(at.absolutePath)
+        minecraft.accessTransformers.file(at)
     }
 
     parchment {

neoforge/gradle.properties

@@ -1,3 +1,3 @@
 # NeoForge, see https://projects.neoforged.net/neoforged/neoforge for new versions
-neoforge_version=20.3.1-beta
+neoforge_version=20.2.3-beta
 neoforge_loader_version_range=[1,)

neoforge/src/main/java/net/lionarius/skinrestorer/neoforge/SkinRestorerNeoForge.java

@@ -6,7 +6,6 @@ import net.neoforged.bus.api.SubscribeEvent;
 import net.neoforged.fml.common.Mod;
 import net.neoforged.neoforge.event.RegisterCommandsEvent;
 import net.neoforged.neoforge.event.server.ServerStartedEvent;
-import net.neoforged.neoforge.event.server.ServerStoppedEvent;
 
 @Mod(SkinRestorer.MOD_ID)
 @Mod.EventBusSubscriber(modid = SkinRestorer.MOD_ID)
@@ -28,9 +27,4 @@ public final class SkinRestorerNeoForge {
     public static void onServerStarted(ServerStartedEvent event) {
         SkinRestorer.Events.onServerStarted(event.getServer());
     }
-    
-    @SubscribeEvent
-    public static void onServerStopped(ServerStoppedEvent event) {
-        SkinRestorer.Events.onServerStopped(event.getServer());
-    }
 }

settings.gradle

@@ -71,4 +71,5 @@ rootProject.name = 'skin-restorer'
 include('common')
 include('fabric')
 include('forge')
-//include('neoforge')
+// There is no NeoForge for versions <1.20.2
+// include('neoforge')