Merge branch '1.20.2-multiloader' into 1.20-multiloader

# Conflicts:
#	settings.gradle

common/src/main/java/net/lionarius/skinrestorer/compat/skinshuffle/SkinShuffleCompatibility.java

@@ -34,7 +34,7 @@ public class SkinShuffleCompatibility {
     public static void handleSkinRefresh(MinecraftServer server, ServerPlayer player, SkinShuffleSkinRefreshPayload payload) {
         var property = payload.textureProperty();
         
-        if (!property.name().equals(PlayerUtils.TEXTURES_KEY))
+        if (!property.getName().equals(PlayerUtils.TEXTURES_KEY))
             return;
         
         if (!property.hasSignature())

common/src/main/java/net/lionarius/skinrestorer/compat/skinshuffle/SkinShuffleHandshakePayload.java

@@ -1,23 +1,10 @@
 package net.lionarius.skinrestorer.compat.skinshuffle;
 
-import net.minecraft.network.FriendlyByteBuf;
-import net.minecraft.network.protocol.common.custom.CustomPacketPayload;
 import net.minecraft.resources.ResourceLocation;
-import org.jetbrains.annotations.NotNull;
 
-public record SkinShuffleHandshakePayload() implements CustomPacketPayload {
+public record SkinShuffleHandshakePayload() {
 
     public static final SkinShuffleHandshakePayload INSTANCE = new SkinShuffleHandshakePayload();
 
     public static final ResourceLocation PACKET_ID = SkinShuffleCompatibility.resourceLocation("handshake");
-
-    @Override
-    public void write(@NotNull FriendlyByteBuf buf) {
-        // NO-OP
-    }
-    
-    @Override
-    public @NotNull ResourceLocation id() {
-        return PACKET_ID;
-    }
 }

common/src/main/java/net/lionarius/skinrestorer/compat/skinshuffle/SkinShuffleSkinRefreshV1Payload.java

@@ -2,34 +2,22 @@ package net.lionarius.skinrestorer.compat.skinshuffle;
 
 import com.mojang.authlib.properties.Property;
 import net.minecraft.network.FriendlyByteBuf;
-import net.minecraft.network.protocol.common.custom.CustomPacketPayload;
 import net.minecraft.resources.ResourceLocation;
-import org.jetbrains.annotations.NotNull;
 
 public record SkinShuffleSkinRefreshV1Payload(
-        Property textureProperty) implements CustomPacketPayload, SkinShuffleSkinRefreshPayload {
+        Property textureProperty) implements SkinShuffleSkinRefreshPayload {
     
     public static final ResourceLocation PACKET_ID = SkinShuffleCompatibility.resourceLocation("refresh");
     
     public static void encode(FriendlyByteBuf buf, SkinShuffleSkinRefreshV1Payload value) {
         var textureProperty = value.textureProperty();
         
-        buf.writeUtf(textureProperty.name());
+        buf.writeUtf(textureProperty.getName());
-        buf.writeUtf(textureProperty.value());
+        buf.writeUtf(textureProperty.getValue());
-        buf.writeNullable(textureProperty.signature(), FriendlyByteBuf::writeUtf);
+        buf.writeNullable(textureProperty.getSignature(), FriendlyByteBuf::writeUtf);
     }
     
     public static SkinShuffleSkinRefreshV1Payload decode(FriendlyByteBuf buf) {
         return new SkinShuffleSkinRefreshV1Payload(new Property(buf.readUtf(), buf.readUtf(), buf.readNullable(FriendlyByteBuf::readUtf)));
     }
-    
-    @Override
-    public void write(@NotNull FriendlyByteBuf buf) {
-        encode(buf, this);
-    }
-    
-    @Override
-    public @NotNull ResourceLocation id() {
-        return PACKET_ID;
-    }
 }

common/src/main/java/net/lionarius/skinrestorer/compat/skinshuffle/SkinShuffleSkinRefreshV2Payload.java

@@ -2,12 +2,10 @@ package net.lionarius.skinrestorer.compat.skinshuffle;
 
 import com.mojang.authlib.properties.Property;
 import net.minecraft.network.FriendlyByteBuf;
-import net.minecraft.network.protocol.common.custom.CustomPacketPayload;
 import net.minecraft.resources.ResourceLocation;
-import org.jetbrains.annotations.NotNull;
 
 public record SkinShuffleSkinRefreshV2Payload(
-        Property textureProperty) implements CustomPacketPayload, SkinShuffleSkinRefreshPayload {
+        Property textureProperty) implements SkinShuffleSkinRefreshPayload {
     
     public static final ResourceLocation PACKET_ID = SkinShuffleCompatibility.resourceLocation("skin_refresh");
 
@@ -15,12 +13,12 @@ public record SkinShuffleSkinRefreshV2Payload(
         var textureProperty = value.textureProperty();
         
         buf.writeBoolean(textureProperty.hasSignature());
-        buf.writeUtf(textureProperty.name());
+        buf.writeUtf(textureProperty.getName());
-        buf.writeUtf(textureProperty.value());
+        buf.writeUtf(textureProperty.getValue());
         if (textureProperty.hasSignature()) {
-            assert textureProperty.signature() != null;
+            assert textureProperty.getSignature() != null;
             
-            buf.writeUtf(textureProperty.signature());
+            buf.writeUtf(textureProperty.getSignature());
         }
     }
 
@@ -30,14 +28,4 @@ public record SkinShuffleSkinRefreshV2Payload(
         }
         return new SkinShuffleSkinRefreshV2Payload(new Property(buf.readUtf(), buf.readUtf(), null));
     }
-    
-    @Override
-    public void write(@NotNull FriendlyByteBuf buf) {
-        encode(buf, this);
-    }
-    
-    @Override
-    public @NotNull ResourceLocation id() {
-        return PACKET_ID;
-    }
 }

common/src/main/java/net/lionarius/skinrestorer/mixin/PlayerListMixin.java

@@ -4,7 +4,6 @@ import net.lionarius.skinrestorer.SkinRestorer;
 import net.minecraft.network.Connection;
 import net.minecraft.server.MinecraftServer;
 import net.minecraft.server.level.ServerPlayer;
-import net.minecraft.server.network.CommonListenerCookie;
 import net.minecraft.server.players.PlayerList;
 import org.spongepowered.asm.mixin.Final;
 import org.spongepowered.asm.mixin.Mixin;
@@ -38,7 +37,7 @@ public abstract class PlayerListMixin {
     }
     
     @Inject(method = "placeNewPlayer", at = @At("HEAD"))
-    private void placeNewPlayer(Connection connection, ServerPlayer player, CommonListenerCookie cookie, CallbackInfo ci) {
+    private void placeNewPlayer(Connection connection, ServerPlayer player, CallbackInfo ci) {
         if (SkinRestorer.getSkinStorage().hasSavedSkin(player.getUUID()))
             SkinRestorer.applySkin(server, Collections.singleton(player.getGameProfile()), SkinRestorer.getSkinStorage().getSkin(player.getUUID()));
     }

common/src/main/java/net/lionarius/skinrestorer/mixin/ServerLoginPacketListenerImplMixin.java

@@ -21,18 +21,18 @@ import java.util.concurrent.CompletableFuture;
 public abstract class ServerLoginPacketListenerImplMixin {
     
     @Shadow @Nullable
-    private GameProfile authenticatedProfile;
+    private GameProfile gameProfile;
     
     @Unique
     private CompletableFuture<Void> skinrestorer$pendingSkin;
     
-    @Inject(method = "verifyLoginAndFinishConnectionSetup", at = @At(value = "INVOKE",
+    @Inject(method = "handleAcceptedLogin", at = @At(value = "INVOKE",
                                                                      target = "Lnet/minecraft/server/players/PlayerList;canPlayerLogin(Ljava/net/SocketAddress;Lcom/mojang/authlib/GameProfile;)Lnet/minecraft/network/chat/Component;"),
             cancellable = true)
     public void waitForSkin(CallbackInfo ci) {
         if (skinrestorer$pendingSkin == null) {
             skinrestorer$pendingSkin = CompletableFuture.supplyAsync(() -> {
-                final var profile = authenticatedProfile;
+                final var profile = gameProfile;
                 
                 assert profile != null;
                 var originalSkin = PlayerUtils.getPlayerSkin(profile);

common/src/main/java/net/lionarius/skinrestorer/skin/provider/ElyBySkinProvider.java

@@ -102,6 +102,6 @@ public final class ElyBySkinProvider implements SkinProvider {
         if (response.statusCode() != 200)
             throw new IllegalArgumentException("no profile with name " + username);
         
-        return JsonUtils.fromJson(response.body(), MinecraftProfilePropertiesResponse.class).toProfile();
+        return PlayerUtils.toProfile(JsonUtils.fromJson(response.body(), MinecraftProfilePropertiesResponse.class));
     }
 }

common/src/main/java/net/lionarius/skinrestorer/skin/provider/MojangSkinProvider.java

@@ -7,7 +7,6 @@ import com.google.common.util.concurrent.UncheckedExecutionException;
 import com.mojang.authlib.GameProfile;
 import com.mojang.authlib.properties.Property;
 import com.mojang.authlib.yggdrasil.response.MinecraftProfilePropertiesResponse;
-import com.mojang.util.UndashedUuid;
 import net.lionarius.skinrestorer.SkinRestorer;
 import net.lionarius.skinrestorer.skin.SkinVariant;
 import net.lionarius.skinrestorer.util.*;
@@ -42,13 +41,13 @@ public final class MojangSkinProvider implements SkinProvider {
             throw new IllegalArgumentException(e);
         }
         
-        PROFILE_CACHE = new GameProfileCache((names, callback) -> {
+        PROFILE_CACHE = new GameProfileCache((names, agent, callback) -> {
             for (var name : names) {
                 try {
                     var profile = MojangSkinProvider.getProfile(name);
                     callback.onProfileLookupSucceeded(profile);
                 } catch (IOException e) {
-                    callback.onProfileLookupFailed(name, e);
+                    callback.onProfileLookupFailed(new GameProfile(null, name), e);
                 }
             }
         }, SkinRestorer.getConfigDir().resolve(PROFILE_CACHE_FILENAME).toFile());
@@ -133,7 +132,7 @@ public final class MojangSkinProvider implements SkinProvider {
         var request = HttpRequest.newBuilder()
                 .uri(MojangSkinProvider.SESSION_SERVER_URI
                         .resolve("/session/minecraft/profile/")
-                        .resolve(UndashedUuid.toString(uuid) + "?unsigned=false")
+                        .resolve(uuid.toString() + "?unsigned=false")
                 )
                 .GET()
                 .build();
@@ -144,6 +143,6 @@ public final class MojangSkinProvider implements SkinProvider {
         if (response.statusCode() != 200)
             throw new IllegalArgumentException("no profile with uuid " + uuid);
         
-        return JsonUtils.fromJson(response.body(), MinecraftProfilePropertiesResponse.class).toProfile();
+        return PlayerUtils.toProfile(JsonUtils.fromJson(response.body(), MinecraftProfilePropertiesResponse.class));
     }
 }

common/src/main/java/net/lionarius/skinrestorer/util/JsonUtils.java

@@ -50,7 +50,7 @@ public final class JsonUtils {
     
     public static JsonObject skinPropertyToJson(Property property) {
         try {
-            JsonObject json = GSON.fromJson(new String(Base64.getDecoder().decode(property.value()), StandardCharsets.UTF_8), JsonObject.class);
+            JsonObject json = GSON.fromJson(new String(Base64.getDecoder().decode(property.getValue()), StandardCharsets.UTF_8), JsonObject.class);
             if (json != null)
                 json.remove("timestamp");
             

common/src/main/java/net/lionarius/skinrestorer/util/PlayerUtils.java

@@ -13,6 +13,7 @@ import net.minecraft.server.level.ChunkMap;
 import net.minecraft.server.level.ServerLevel;
 import net.minecraft.server.level.ServerPlayer;
 import net.minecraft.server.players.PlayerList;
+import net.minecraft.world.level.biome.BiomeManager;
 
 import java.util.*;
 
@@ -67,7 +68,20 @@ public final class PlayerUtils {
         }
         
         if (!player.isDeadOrDying()) {
-            player.connection.send(new ClientboundRespawnPacket(player.createCommonSpawnInfo(serverLevel), ClientboundRespawnPacket.KEEP_ALL_DATA));
+            player.connection.send(
+                    new ClientboundRespawnPacket(
+                            player.level().dimensionTypeId(),
+                            player.level().dimension(),
+                            BiomeManager.obfuscateSeed(player.serverLevel().getSeed()),
+                            player.gameMode.getGameModeForPlayer(),
+                            player.gameMode.getPreviousGameModeForPlayer(),
+                            player.level().isDebug(),
+                            player.serverLevel().isFlat(),
+                            (byte) 3,
+                            player.getLastDeathLocation(),
+                            player.getPortalCooldown()
+                    )
+            );
             player.connection.teleport(player.getX(), player.getY(), player.getZ(), player.getYRot(), player.getXRot());
             player.connection.send(new ClientboundSetEntityMotionPacket(player));
             var vehicle = player.getVehicle();
@@ -122,8 +136,8 @@ public final class PlayerUtils {
     }
     
     public static GameProfile toProfile(MinecraftProfilePropertiesResponse response) {
-        final GameProfile profile = new GameProfile(response.id(), response.name());
+        final GameProfile profile = new GameProfile(response.getId(), response.getName());
-        profile.getProperties().putAll(response.properties());
+        profile.getProperties().putAll(response.getProperties());
         return profile;
     }
 }

forge/src/main/java/net/lionarius/skinrestorer/forge/compat/skinshuffle/SkinShufflePacketHandler.java

@@ -1,57 +1,65 @@
 package net.lionarius.skinrestorer.forge.compat.skinshuffle;
 
 import io.netty.buffer.Unpooled;
-import net.lionarius.skinrestorer.compat.skinshuffle.*;
 import net.lionarius.skinrestorer.compat.skinshuffle.SkinShuffleCompatibility;
+import net.lionarius.skinrestorer.compat.skinshuffle.*;
 import net.minecraft.network.Connection;
 import net.minecraft.network.FriendlyByteBuf;
-import net.minecraftforge.event.network.CustomPayloadEvent;
+import net.minecraft.network.protocol.game.ClientboundCustomPayloadPacket;
-import net.minecraftforge.network.ChannelBuilder;
+import net.minecraftforge.network.NetworkEvent;
-import net.minecraftforge.network.EventNetworkChannel;
+import net.minecraftforge.network.NetworkRegistry;
+import net.minecraftforge.network.event.EventNetworkChannel;
 
 public class SkinShufflePacketHandler {
     private SkinShufflePacketHandler() {
     }
-
+    
-    private static final EventNetworkChannel HANDSHAKE_INSTANCE = ChannelBuilder
+    private static final EventNetworkChannel HANDSHAKE_INSTANCE = NetworkRegistry.ChannelBuilder
             .named(SkinShuffleHandshakePayload.PACKET_ID)
-            .optional()
+            .clientAcceptedVersions(NetworkRegistry.acceptMissingOr(""))
+            .serverAcceptedVersions(NetworkRegistry.acceptMissingOr(""))
+            .networkProtocolVersion(() -> "")
             .eventNetworkChannel();
     
-    private static final EventNetworkChannel SKIN_REFRESH_V1_INSTANCE = ChannelBuilder
+    private static final EventNetworkChannel SKIN_REFRESH_V1_INSTANCE = NetworkRegistry.ChannelBuilder
             .named(SkinShuffleSkinRefreshV1Payload.PACKET_ID)
-            .optional()
+            .clientAcceptedVersions(NetworkRegistry.acceptMissingOr(""))
-            .eventNetworkChannel()
+            .serverAcceptedVersions(NetworkRegistry.acceptMissingOr(""))
-            .addListener(SkinShufflePacketHandler::skinRefreshV1Listener);
+            .networkProtocolVersion(() -> "")
+            .eventNetworkChannel();
     
-    private static final EventNetworkChannel SKIN_REFRESH_V2_INSTANCE = ChannelBuilder
+    private static final EventNetworkChannel SKIN_REFRESH_V2_INSTANCE = NetworkRegistry.ChannelBuilder
             .named(SkinShuffleSkinRefreshV2Payload.PACKET_ID)
-            .optional()
+            .clientAcceptedVersions(NetworkRegistry.acceptMissingOr(""))
-            .eventNetworkChannel()
+            .serverAcceptedVersions(NetworkRegistry.acceptMissingOr(""))
-            .addListener(SkinShufflePacketHandler::skinRefreshV2Listener);
+            .networkProtocolVersion(() -> "")
-
+            .eventNetworkChannel();
+    
     protected static void initialize() {
-        // NO-OP
+        SKIN_REFRESH_V1_INSTANCE.addListener(SkinShufflePacketHandler::skinRefreshV1Listener);
-    }
+        SKIN_REFRESH_V2_INSTANCE.addListener(SkinShufflePacketHandler::skinRefreshV2Listener);
-
-    public static void sendHandshake(Connection connection) {
-        HANDSHAKE_INSTANCE.send(new FriendlyByteBuf(Unpooled.buffer(0, 0)), connection);
     }
     
-    private static void skinRefreshV1Listener(CustomPayloadEvent event) {
+    public static void sendHandshake(Connection connection) {
+        connection.send(new ClientboundCustomPayloadPacket(SkinShuffleHandshakePayload.PACKET_ID, new FriendlyByteBuf(Unpooled.buffer(0, 0))));
+    }
+    
+    private static void skinRefreshV1Listener(NetworkEvent.ClientCustomPayloadEvent event) {
         var payload = SkinShuffleSkinRefreshV1Payload.decode(event.getPayload());
-        handleSkinRefreshPacket(payload, event.getSource());
+        handleSkinRefreshPacket(payload, event.getSource().get());
+        event.getSource().get().setPacketHandled(true);
     }
-
+    
-    private static void skinRefreshV2Listener(CustomPayloadEvent event) {
+    private static void skinRefreshV2Listener(NetworkEvent.ClientCustomPayloadEvent event) {
         var payload = SkinShuffleSkinRefreshV2Payload.decode(event.getPayload());
-        handleSkinRefreshPacket(payload, event.getSource());
+        handleSkinRefreshPacket(payload, event.getSource().get());
+        event.getSource().get().setPacketHandled(true);
     }
-
+    
-    private static void handleSkinRefreshPacket(SkinShuffleSkinRefreshPayload payload, CustomPayloadEvent.Context context) {
+    private static void handleSkinRefreshPacket(SkinShuffleSkinRefreshPayload payload, NetworkEvent.Context context) {
         var sender = context.getSender();
         
-        if (!context.isServerSide() || sender == null)
+        if (!context.getDirection().getReceptionSide().isServer() || sender == null)
             return;
         
         SkinShuffleCompatibility.handleSkinRefresh(sender.getServer(), sender, payload);

forge/src/main/java/net/lionarius/skinrestorer/forge/platform/ForgeCompatibilityHelper.java

@@ -8,6 +8,6 @@ public final class ForgeCompatibilityHelper implements CompatibilityHelper {
     
     @Override
     public void skinShuffle_sendHandshake(ServerPlayer player) {
-        SkinShufflePacketHandler.sendHandshake(player.connection.getConnection());
+        SkinShufflePacketHandler.sendHandshake(player.connection.connection);
     }
 }

gradle.properties

@@ -3,9 +3,9 @@ group=net.lionarius
 java_version=17
 
 # Common
-minecraft_version=1.20.2
+minecraft_version=1.20
-minecraft_version_list=1.20.2
+minecraft_version_list=1.20,1.20.1
-minecraft_version_range=1.20.2
+minecraft_version_range=[1.20, 1.20.1]
 mod_id=skinrestorer
 mod_name=SkinRestorer
 mod_version=2.2.0
@@ -20,8 +20,8 @@ description=A server-side mod for managing skins.
 mineskin_client_version=3.0.1-SNAPSHOT
 
 # ParchmentMC mappings, see https://parchmentmc.org/docs/getting-started#choose-a-version for new versions
-parchment_minecraft=1.20.2
+parchment_minecraft=1.20.1
-parchment_version=2023.12.10
+parchment_version=2023.09.03
 
 # Fabric, see https://fabricmc.net/develop/ for new versions
 fabric_loader_version=0.15.0
@@ -29,10 +29,10 @@ fabric_api_version=0.91.1+1.20.3
 fabric_optional_dependencies=fabric-api
 
 # Forge, see https://files.minecraftforge.net/net/minecraftforge/forge/ for new versions
-forge_version=48.0.0
+forge_version=46.0.1
-forge_loader_version_range=[48,)
+forge_loader_version_range=[46,)
 # Forge sometimes skips minor minecraft versions (like 1.20.5)
-forge_minecraft_version=1.20.2
+forge_minecraft_version=1.20
 
 # NeoForge, see https://projects.neoforged.net/neoforged/neoforge for new versions
 neoforge_version=20.2.3-beta

settings.gradle

@@ -71,4 +71,5 @@ rootProject.name = 'skin-restorer'
 include('common')
 include('fabric')
 include('forge')
-//include('neoforge')
+// There is no NeoForge for versions <1.20.2
+// include('neoforge')